Remove unnecessary dependencies in every CaseStudies #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
Oct 15, 2022
Jager-yoo
commented
Oct 15, 2022
Comment on lines
+122
to
+135
| // MARK: - SwiftUI previews | ||
|
|
||
| struct NestedView_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| NavigationView { | ||
| NestedView( | ||
| store: Store( | ||
| initialState: .mock, | ||
| reducer: Nested() | ||
| ) | ||
| } | ||
| ) | ||
| } | ||
| } | ||
| #endif | ||
| } |
There was a problem hiding this comment.
I'm not sure if it's okay to remove if DEBUG.
| @@ -1,5 +1,4 @@ | |||
| import ComposableArchitecture | |||
| import Foundation | |||
There was a problem hiding this comment.
Note: This was added at Concurrency Beta (#1189)
| import ComposableArchitecture | ||
| import Foundation |
There was a problem hiding this comment.
Note: This was added at Concurrency Beta (#1189)
| @@ -1,6 +1,5 @@ | |||
| import AVFoundation | |||
| import ComposableArchitecture // TODO: Should `UncheckedSendable` live in `Dependencies`? | |||
| import Foundation | |||
There was a problem hiding this comment.
Note: This was added at Concurrency Beta (#1189)
| @@ -1,6 +1,5 @@ | |||
| import AVFoundation | |||
| import ComposableArchitecture | |||
| import Foundation | |||
There was a problem hiding this comment.
Note: This was added at Concurrency Beta (#1189)
| @@ -1,5 +1,4 @@ | |||
| import ComposableArchitecture | |||
| import Foundation | |||
There was a problem hiding this comment.
Note: This was added at Concurrency Beta (#1189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋🏻
I removed imported dependencies that don't affect building and testing in every CaseStudies.
Most of them are
Combine, but someFoundationwere added relatively recently at thisConcurrency Beta#1189Removing them didn't have any build issues, but there could be reasons I'm not aware of.
I'll leave comments below. Please check.
and I added
MARK headersto each file in SwiftUI - CaseStudies for readability, in 3 simple categories.Please refer to the capture below.