Fixes for the 'Basic Usage' to allow project to build and run #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrapperon
reviewed
Oct 15, 2022
README.md
Outdated
| } | ||
| } | ||
| ``` | ||
|
|
||
| You may also find that the HTTP API request to numbersapi.com is blocked as only HTTPS connections are permitted. If this happens you can add an exception to the project settings to allow HTTP requests just for the numbersapi.com domain. |
There was a problem hiding this comment.
This seems to be a lot of unrelated information to display inline in a README. If it stays in the final version of this PR, it would probably be better to be hidden in a details/summary tag:
<details>
<summary>
About `http://numbersapi.com`
</summary>
You may also find that the HTTP API request to […]
</details>But I think it can probably go away, so please wait for other's feedback before making drastic changes.
There was a problem hiding this comment.
I agree, let this go which just leaves minor changes to using the samples in a cut/paste fashion
tgrapperon
added a commit
to tgrapperon/swift-composable-architecture
that referenced
this pull request
Oct 15, 2022
Caught while reviewing pointfreeco#1507.
stephencelis
pushed a commit
that referenced
this pull request
Oct 15, 2022
Caught while reviewing #1507.
mbrandonw
reviewed
Oct 16, 2022
mbrandonw
reviewed
Oct 16, 2022
Co-authored-by: Brandon Williams <[email protected]>
stephencelis
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New to TCA (and Swift for that matter) and was just building the Basic Usage section and ran into some minor errors, these minor changes correct the steps so you can build and run the example.
Using the latest Xcode and Swift 5.7 and the new TCA ReducerProtocol builds. Key changes are: