Skip to content

Improve the layout of Web Socket case study #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

Jager-yoo
Copy link
Contributor

Hi, I improved the layout of Web Socket case study.
Let me know what you think. Thank you! 😄

  • The layout of the Web Socket was different from that of other cases. I modified it to have the same tone and manner.
  • Also, there are multiple blue text buttons clustered together, making it a bit confusing. I modified it so that the roles of buttons are clearly distinguished.
  • Messages are now stacking upward. And when re-connecting, the stacked messages are removed.
  • I changed some text.

Please check out gif examples below. (1.5x speed)

as-is to-be

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better, thanks for taking the time!

@mbrandonw mbrandonw merged commit c1302e5 into pointfreeco:main Oct 19, 2022
@Jager-yoo Jager-yoo deleted the improve-websocket-example branch October 20, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants