Skip to content

refactor : remove unnecessary conformance to Sendable Protocol #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

inwoodev
Copy link
Contributor

Since all the members are sendable, the WeatherClient does not need to conform to Sendable Protocol explicitly. It is implicitly Sendable.

@mbrandonw
Copy link
Member

Good catch, thanks!

One thing to keep in mind is that if the WeatherClient ever moves to its own module it will then need to explicitly conform to Sendable. The implicit conformance only works in the same module the type is defined in.

@mbrandonw mbrandonw merged commit 17ec3d9 into pointfreeco:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants