Add a few missing tests #1539
Merged
Add a few missing tests #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Oct 21, 2022
| } | ||
|
|
||
| #if os(macOS) |
There was a problem hiding this comment.
not sure why this was marked as macOS only... seems to work fine on iOS.
mbrandonw
commented
Oct 21, 2022
| An "EffectTask.task" returned from \ | ||
| "ComposableArchitectureTests/EffectFailureTests.swift:\(line+1)" threw an unhandled \ | ||
| error. … | ||
| An "EffectTask.task" returned from "\(#fileID):\(line+1)" threw an unhandled error. … |
There was a problem hiding this comment.
pushed a small update to make some of our test failure tests a bit more resilient by using #fileID instead of hard coding the file name. This makes it so that if we rename the file it does not break tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at code coverage reports I noticed we had a few missing tests, so just filling some of that in. There's more that could be done.