Avoid failure when setting test dependency values #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently possible to emit XCTest failures when testing reducers that access dependency values that emit failure upon access, which includes the calendar, locale, time zone, and URL session dependencies. We may need a more holistic solution for folks that define these kinds of dependencies outside the library, but this will make the library-level failures a bit more lenient.
mbrandonw
approved these changes
Oct 25, 2022
jeffersonsetiawan
added a commit
to tokopedia/RxComposableArchitecture
that referenced
this pull request
Jan 5, 2023
jeffersonsetiawan
added a commit
to tokopedia/RxComposableArchitecture
that referenced
this pull request
Feb 6, 2023
* add dependencies and its test * update effect and reducer * add reducers, rename anyreducer, delete xct related files * extract storeconfig * task result and task cancellable value * observable * effect * fix package swift * any disposable * import xctdynamicoverlay * update effects * make any disposable public * fix any reducer compatibility * first passed test 5.7 * refactor package.swift * remove anyequatable double * update store * wrap in discardable * [TestStore] - Update to conform changes ReducerProtocol (#65) * progress update teststore * progressing update TestStore * Fixing TestStore & make it success run test * update indent code TestStore, add comment for send action assert testStore * change observable * update observable * rename conflicted name * undo * add flatmap * add xctest dynamic overlay podspec * add xctdo podspec * update exports.swift * update podspec * update typo podspec * fix dispose issue * restructure dependency module, fix test, update podspec and package.swift * update store old behaviour, fix store tests * remove unused code * fix flatmap, add StoreOf * update teststore generics order, remove all spi internals * Rewrite example using Reducer Protocol style (#63) * update store, rewrite basic and scoping example * rewrite environment example * rewrite pullback vc example * update counterview, rewrite iflet * rewrite never equal * update timer example * update test * update old scope and store tests * use OptionalPath * remove duplicated StoreConfig * add ACL for TestReducer class & property * fix default value for useNewScope in StoreConfig * [Reducer Protocol] - Add New Test Cases (#68) * fix passing useNewScope to Store from TestStore * add new test to TestStore * add new TestStoreTest cases * update to fix async task cancel * update StoreTest test case * add more StoreTests test cases * update failingWhenNothingChanges to true by default on new TestStore code * update & add new cases for TestStoreTest * remove import combine * separate oldScope & newScope test on Storetest and TestStoreTest * update testcases based on new default value for for Store and TestStore * [Reducer Protocol] - Support Bootstrap MockKit (#70) Support our Bootstrap MockKit when using ReducerProtocol Dependency Environment * update pullback vc * bump xcode versions * update ci.yml to use xcode 14.1 for example tests * update ci yml again for xcode 14.1 * refactor ci.yml * update xcode 14 1 name * sync with 0.44.1 minus PR 1510 and EffectTask * fix warning * Fix Reducer builder inference issue: pointfreeco/swift-composable-architecture#1591 Implement Test Pt1 * adding more test, still failing dependency test on both store and teststore * pointfreeco/swift-composable-architecture#1570 pointfreeco/swift-composable-architecture#1575 * add usenewscope * Sync Cancellation * Readd PR #1510 and add tests, fix tests examples * add optional reducer, update dependency values tests with binding * sync up to 0.46.0 * sync up to 0.47.2 * sync up to 0.48.0 * bump xctestdynamicoverlay * remove assert function on teststore * add failing when nothing change on scope teststore * update store send and mainqueue syntax --------- Co-authored-by: Andhika Setiadi <[email protected]> Co-authored-by: Jefferson Setiawan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible to emit XCTest failures when testing reducers that access dependency values that emit failure upon access, which includes the calendar, locale, time zone, and URL session dependencies.
We may need a more holistic solution for folks that define these kinds of dependencies outside the library, but this will make the library-level failures a bit more lenient.