Depend on SwiftUINavigation for TextState, AlertState, etc... #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Nov 21, 2022
Comment on lines
-847
to
-855
| extension AlertState.Button { | ||
| @available( | ||
| *, deprecated, message: "Cancel buttons must be given an explicit label as their first argument" | ||
| ) | ||
| public static func cancel(action: AlertState.ButtonAction? = nil) -> Self { | ||
| .init(action: action, label: TextState("Cancel"), role: .cancel) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This wasn't compiling so I just removed since it's so old. But I can debug it if we don't want to remove yet.
mbrandonw
commented
Nov 21, 2022
Comment on lines
-1042
to
-1044
| // MARK: - Deprecated after 0.23.0: | ||
|
|
||
| extension AlertState.Button { |
There was a problem hiding this comment.
Same with all of this.
mbrandonw
commented
Nov 21, 2022
Package.swift
Outdated
| @@ -28,6 +28,7 @@ let package = Package( | |||
| .package(url: "https://github.com/pointfreeco/swift-clocks", from: "0.1.4"), | |||
| .package(url: "https://github.com/pointfreeco/swift-custom-dump", from: "0.6.0"), | |||
| .package(url: "https://github.com/pointfreeco/swift-identified-collections", from: "0.4.1"), | |||
| .package(url: "https://github.com/pointfreeco/swiftui-navigation", branch: "fixes"), | |||
There was a problem hiding this comment.
I think we need the changes in this branch in order to integrate with TCA.
stephencelis
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have extracted
TexState,AlertStateandConfirmationDialogStatefrom this library and put it in our SwiftUINavigation library so that vanilla SwiftUI can take advantage of those tools. TCA will now depend on SwiftUINavigation, but not all of it. Just on a small, "internal" library called _SwiftUINavigationState.