Bump SwiftUINavigation and update examples #1760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating some examples to use the new
AlertStateandConfirmationDialogStateinitializers, I thought it would probably be worth bumping SwiftUINavigation to the latest version.I had a feeling the examples didn't need to support a minimum version but was unsure. I just updated what I could find.
In addition to updating the examples I have included some small fixes I noticed along the way. Happy to create separate PRs if needed.
Summary of changes:
AlertStateandConfirmationDialogStateSearchexampleTestClockfromReusableComponentsFavoritingTests5.6and platform requirement to.iOS(.v15)forTicTacToeexample and madeLoginsendableschemevariable in Makefiletest-examplessoCaseStudies (SwiftUI)CaseStudies (UIKit)are passed correctly toxcodebuild test -scheme. Currently being passed asxcodebuild test -scheme CaseStudies "(SwiftUI)"which results inxcodebuild: error: Unknown build action '(SwiftUI)'