Skip to content

Make TestStore.receive actually match the action predicate #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pyrtsa
Copy link
Contributor

@pyrtsa pyrtsa commented Jan 2, 2023

When calling TestStore.receive(_:…) with a predicate or a case path and exhaustivity on, the current code in main never actually calls the matching predicate. This PR fixes that, with unit tests.

@pyrtsa
Copy link
Contributor Author

pyrtsa commented Jan 2, 2023

While at it, I should probably also update the docs which refer to a non-existent matchingAction closure currently. 🤔 Will see about that tomorrow.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for catching this! Will take a look at those docs for you 😄

@stephencelis stephencelis merged commit 5f294b9 into pointfreeco:main Jan 3, 2023
@pyrtsa pyrtsa deleted the test-store-receive-should-match-predicate branch January 4, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants