Skip to content

Add prepareDependencies to Store.init #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Add prepareDependencies to Store.init #1844

merged 5 commits into from
Jan 18, 2023

Conversation

stephencelis
Copy link
Member

Seems useful to have Store mirror TestStore here.

I've also updated all our tests to prefer this initializer, as it's a bit less noisy for declaring upfront dependencies.

@acosmicflamingo
Copy link
Contributor

Oh this is nice; can't wait to clean up some of my tests using this new closure :)

@stephencelis
Copy link
Member Author

@acosmicflamingo This helper was actually introduced to TestStore awhile back! This PR just updates our tests to actually use it, and introduces the corresponding initializer on Store, which can be helpful to configure certain live dependencies at the root of your application.

@acosmicflamingo
Copy link
Contributor

@acosmicflamingo This helper was actually introduced to TestStore awhile back! This PR just updates our tests to actually use it, and introduces the corresponding initializer on Store, which can be helpful to configure certain live dependencies at the root of your application.

Oh neat! Perhaps that was merged before I signed up to get email notifications anytime anything happens in this repo like a stalker ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants