Rename BindableState to BindingState
#1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -`able` naming evokes protocols in Swift, and is an outlier when considered alongside the rest of TCA's binding tools: - `BindingAction`: concrete type - `BindableAction`: protocol - `BindingReducer`: concrete type So, let's make things consistent. The one caveat is that Swift diagnostics for such a deprecation aren't great, so users won't get proactive warnings here for the time being: swiftlang/swift#63139 We may just want to keep the deprecation around till it does...
mbrandonw
approved these changes
Jan 20, 2023
@stephencelis was there a plan on using |
|
@iampatbrown There have been experiments run by @tgrapperon for such a thing, so it'd be nice to free up the namespace if we need it. No concrete plans as of yet, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -
ablenaming evokes protocols in Swift, and is an outlier when considered alongside the rest of TCA's binding tools:BindingAction: concrete typeBindableAction: protocolBindingReducer: concrete typeSo, let's make things consistent and rename
@BindableStateto@BindingState.The one caveat is that Swift diagnostics for such a deprecation aren't great, so users won't get proactive warnings here for the time being:
swiftlang/swift#63139
We may just want to keep the deprecation around till it does...