Improve TestStore.init ergonomics
#1857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And introduce `TestStore.init(initialState:reducer:observe:send:)` for testing scoped state and actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit easy to dive into testing and be met with bad ergonomics if you forgot to conform
Stateto beEquatable. Right now it doesn't requireEquatablebecause it's possible to scope test stores and assert against view state/actions. This feature is pretty niche, though, and shouldn't make the more general case painful, so let's take a few steps to improve things:TestStore.initthat takes non-equatable stateTestStore.init(…:observe:send:…)for testing view state/actions.TestStore.scope(scoping a test store multiple times doesn't seem useful enough to support).