Skip to content

Unavailable TestStore.send/receive when state/action is not Equatable #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2023

Conversation

mbrandonw
Copy link
Member

@mbrandonw mbrandonw commented Feb 3, 2023

Now that TestStore requires equatable state, we lose a bit of autocomplete and create a confusing situation while the user has to figure out how to fix.

We can help things along by defining a unavailable send/receive methods when state/action are not equatable, which helps with autocomplete, but also immediately tells the user what is wrong.

@mbrandonw mbrandonw merged commit 3b1fabe into main Feb 5, 2023
@mbrandonw mbrandonw deleted the unavailable-send-receive branch February 5, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants