Force WithViewStore to be a view. #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
Feb 15, 2023
|
Indeed, this is a huge improvement. I remember #1204 where locking |
|
What if we had a (I didn't know WithViewStore used to work with Scenes until after I wrote this proposal.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various initializers on
WithViewStorefor dealing with scenes, toolbars, etc. have been deprecated for over 5 months now. We did that because they can cause strain on the compiler, and we are seeing that more and more, so we think it's finally time to delete them.And once that is done we can now make
WithViewStorealways be aViewrather than conditionally. We have found this helps type checking and compiling performance quite a bit, especially for previews where I guess due to the dynamic replacement mechanism type checking can be even slower.