Nest Send<Action> as Effect<Action>.Send
#1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
Send<Action>being a top-level type makes it the preferred autocompletion choice when you type "Send…" to make some typeSendable(a very frequent operation). This is suboptimal.Fortunately, this value is always provided by the library in standard operations, and the user usually doesn't have to handle its type directly. This PR relocates
Send<Action>inEffectTask<Action>.Send(that isEffectPublisher<Action, Never>.Send, but it should transparently migrate toEffect<Action>.Sendfor thev1.0.). The current top-levelSendis deprecated (which lowers its autocompletion rank and gives way toSendable), but this shouldn't impact existing user code which should seamlessly resolve toEffect<Action>.Sendinstead ofSend<Action>in the vast majority of cases.It doesn't seem possible to provide a
rename:argument to the deprecation annotation.