Skip to content

Bump Xcode settings #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1250"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
5 changes: 3 additions & 2 deletions Examples/CaseStudies/CaseStudies.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
objectVersion = 52;
objectVersion = 53;
objects = {

/* Begin PBXBuildFile section */
Expand Down Expand Up @@ -593,8 +593,9 @@
DC89C40B24460F95006900B9 /* Project object */ = {
isa = PBXProject;
attributes = {
BuildIndependentTargetsInParallel = YES;
LastSwiftUpdateCheck = 1150;
LastUpgradeCheck = 1240;
LastUpgradeCheck = 1430;
ORGANIZATIONNAME = "Point-Free";
TargetAttributes = {
CAF88E6F24B8E26D00539345 = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1320"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1420"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
5 changes: 3 additions & 2 deletions Examples/VoiceMemos/VoiceMemos.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
objectVersion = 52;
objectVersion = 53;
objects = {

/* Begin PBXBuildFile section */
Expand Down Expand Up @@ -209,8 +209,9 @@
DC5BDCA224589177009C65A3 /* Project object */ = {
isa = PBXProject;
attributes = {
BuildIndependentTargetsInParallel = YES;
LastSwiftUpdateCheck = 1140;
LastUpgradeCheck = 1240;
LastUpgradeCheck = 1430;
ORGANIZATIONNAME = "Point-Free";
TargetAttributes = {
DC5BDCA924589177009C65A3 = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1240"
LastUpgradeVersion = "1430"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
83 changes: 44 additions & 39 deletions Tests/ComposableArchitectureTests/EffectRunTests.swift
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Combine
import ComposableArchitecture
@_spi(Concurrency) import Dependencies
import XCTest

@MainActor
Expand Down Expand Up @@ -43,34 +44,36 @@ final class EffectRunTests: BaseTCATestCase {

#if DEBUG
func testRunUnhandledFailure() async {
var line: UInt!
XCTExpectFailure(nil, enabled: nil, strict: nil) {
$0.compactDescription == """
await withMainSerialExecutor {
var line: UInt!
XCTExpectFailure(nil, enabled: nil, strict: nil) {
$0.compactDescription == """
An "EffectTask.run" returned from "\(#fileID):\(line+1)" threw an unhandled error. …

EffectRunTests.Failure()

All non-cancellation errors must be explicitly handled via the "catch" parameter on \
"EffectTask.run", or via a "do" block.
"""
}
struct State: Equatable {}
enum Action: Equatable { case tapped, response }
let reducer = Reduce<State, Action> { state, action in
switch action {
case .tapped:
line = #line
return .run { send in
struct Failure: Error {}
throw Failure()
}
struct State: Equatable {}
enum Action: Equatable { case tapped, response }
let reducer = Reduce<State, Action> { state, action in
switch action {
case .tapped:
line = #line
return .run { send in
struct Failure: Error {}
throw Failure()
}
case .response:
return .none
}
case .response:
return .none
}
let store = TestStore(initialState: State(), reducer: reducer)
// NB: We wait a long time here because XCTest failures take a long time to generate
await store.send(.tapped).finish(timeout: 5 * NSEC_PER_SEC)
}
let store = TestStore(initialState: State(), reducer: reducer)
// NB: We wait a long time here because XCTest failures take a long time to generate
await store.send(.tapped).finish(timeout: 5 * NSEC_PER_SEC)
}
#endif

Expand Down Expand Up @@ -120,8 +123,9 @@ final class EffectRunTests: BaseTCATestCase {

#if DEBUG
func testRunEscapeFailure() async throws {
XCTExpectFailure {
$0.compactDescription == """
try await withMainSerialExecutor {
XCTExpectFailure {
$0.compactDescription == """
An action was sent from a completed effect:

Action:
Expand All @@ -136,32 +140,33 @@ final class EffectRunTests: BaseTCATestCase {
To fix this, make sure that your 'run' closure does not return until you're done calling \
'send'.
"""
}
}

enum Action { case tap, response }
enum Action { case tap, response }

let queue = DispatchQueue.test
let queue = DispatchQueue.test

let store = Store(
initialState: 0,
reducer: Reduce<Int, Action> { _, action in
switch action {
case .tap:
return .run { send in
Task(priority: .userInitiated) {
try await queue.sleep(for: .seconds(1))
await send(.response)
let store = Store(
initialState: 0,
reducer: Reduce<Int, Action> { _, action in
switch action {
case .tap:
return .run { send in
Task(priority: .userInitiated) {
try await queue.sleep(for: .seconds(1))
await send(.response)
}
}
case .response:
return .none
}
case .response:
return .none
}
}
)
)

let viewStore = ViewStore(store, observe: { $0 })
await viewStore.send(.tap).finish()
await queue.advance(by: .seconds(1))
let viewStore = ViewStore(store, observe: { $0 })
await viewStore.send(.tap).finish()
await queue.advance(by: .seconds(1))
}
}

func testRunEscapeFailurePublisher() async throws {
Expand Down