Skip to content

mWeb: Keyboard Shortcuts Content Overflow in Mobile View #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arpitghura opened this issue Jan 7, 2024 · 5 comments · Fixed by #2932
Closed

mWeb: Keyboard Shortcuts Content Overflow in Mobile View #2866

arpitghura opened this issue Jan 7, 2024 · 5 comments · Fixed by #2932
Labels
Area:CSS For styling or layout issues handled with CSS/SASS Area: Mobile For issues affecting mobile or responsive behavior Bug Error or unexpected behaviors

Comments

@arpitghura
Copy link

arpitghura commented Jan 7, 2024

p5.js version

1.9.0

What is your operating system?

Android

Web browser and version

120.0.6099.199

Actual Behavior

The content in the keyboard shortcut is going beyond the parent container (Modal).

image

Expected Behavior

The content should wrap inside the parent container (Modal).

Steps to reproduce

Steps:

  1. Open in Mobile View
  2. Click on three dot Menu
  3. Click on Keyboard Shortcuts
@arpitghura arpitghura added the Bug Error or unexpected behaviors label Jan 7, 2024
Copy link

welcome bot commented Jan 7, 2024

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@arpitghura
Copy link
Author

I would like to contribute to this. Can you please assign this to me?

@Ri-Sharma
Copy link
Contributor

Hey @arpitghura, using min-inline-size: max-content; was pretty neat.
But there is an problem with max-width: #{500 / $base-font-size}rem; whenever we use a screen size that is wider, there is an abnormal gap between the scroll bar and screen end like following;
Screenshot 2024-01-20 224022

So instead of max-width: #{500 / $base-font-size}rem; we can just use width : 100% this would prevent the overflow and prevent the scroll bar problem.

@Ri-Sharma
Copy link
Contributor

Just added that :)

@raclim raclim added Area: Mobile For issues affecting mobile or responsive behavior Area:CSS For styling or layout issues handled with CSS/SASS labels Jan 22, 2024
@raclim
Copy link
Collaborator

raclim commented Mar 29, 2024

Thanks for raising this issue! I'm going to go with #2932, but I think the resolution for this was definitely found through the solutions of both @arpitghura and @Ri-Sharma!

raclim added a commit that referenced this issue Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:CSS For styling or layout issues handled with CSS/SASS Area: Mobile For issues affecting mobile or responsive behavior Bug Error or unexpected behaviors
Projects
None yet
3 participants