-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Updating visual tests docs for 2.x versions #7827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.0
Are you sure you want to change the base?
Updating visual tests docs for 2.x versions #7827
Conversation
Hi @davepagurek @ksen0, while reviewing |
contributor_docs/unit_testing.md
Outdated
@@ -217,13 +224,11 @@ visualTest('2D objects maintain correct size', function(p5, screenshot) { | |||
}); | |||
``` | |||
|
|||
If you need to add a new test file, add it to that folder, then add the filename to the list in `test/visual/visualTestList.js`. Additionally, if you want that file to be run automatically as part of continuous integration on every pull request, add the filename to the `visual` list in `test/unit/spec.js`. | |||
No manual registration necessary. Any file placed in `test/unit/visual/cases` is auto-discovered by Vitest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: "To add a new test file, place it into test/unit/visual/cases
. This will be auto-discovered by Vitest - no manual registration needed."
Thanks @ksen0 , I can work on your suggestion asap. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @perminder-17 !
Fixing docs for unit/visual testings.