Skip to content

feat: laravel 12.x compatibility #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 12.x.

Before merging, you need to:

  • Checkout the l12-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 12. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-jsvalidation.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "proengsoft/laravel-jsvalidation": "dev-l12-compatibility",
    }
}

Finally, run: composer update

@danielrona
Copy link

This seems to work fine (so far)

@bytestream bytestream changed the title Laravel 12.x Compatibility feat: laravel 12.x compatibility Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.10%. Comparing base (eadeb21) to head (e596b3f).
Report is 27 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1047   +/-   ##
=========================================
  Coverage     97.10%   97.10%           
- Complexity      190      191    +1     
=========================================
  Files            18       18           
  Lines           519      519           
=========================================
  Hits            504      504           
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytestream bytestream merged commit ed4c438 into proengsoft:master Feb 25, 2025
15 checks passed
@jsvalidation-release
Copy link
Collaborator

🎉 This PR is included in version 4.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants