Skip to content

New RowIds feature and select column storage across data refresh #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 12, 2014
Merged

New RowIds feature and select column storage across data refresh #12

merged 12 commits into from
Nov 12, 2014

Conversation

ithielnor
Copy link
Collaborator

No description provided.

ithielnor added a commit that referenced this pull request Nov 12, 2014
New RowIds feature and select column storage across data refresh
@ithielnor ithielnor merged commit 06cdfe8 into programcsharp:master Nov 12, 2014
inputs += "<input name=\"ids\" value=\"" + this + "\" />";
$.each(selection, function () {
$.each(this, function () {
inputs += "<input name=\"ids\" value=\"" + this + "\" />";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use the id name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think you're right. I'll fix.

On Wed, Nov 12, 2014 at 4:20 PM, Chris Hynes [email protected]
wrote:

In Griddly/Scripts/griddly.js:

@@ -937,9 +1009,10 @@
if (token.length)
inputs += '<input type="hidden" name="' + token.attr("name") + '" value="' + token.val() + '" />';

  •    $.each(ids, function ()
    
  •    {
    
  •        inputs += "<input name=\"ids\" value=\"" + this + "\" />";
    
  •    $.each(selection, function () {
    
  •        $.each(this, function () {
    
  •            inputs += "<input name=\"ids\" value=\"" + this + "\" />";
    

Should this use the id name?


Reply to this email directly or view it on GitHub
https://github.com/programcsharp/griddly/pull/12/files#r20252404.

ithielnor pushed a commit that referenced this pull request Jun 4, 2018
Tighten up selection display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants