v8: use signal handlers to catch out of bounds memory access. #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves performance by up to 36% in microbenchmarks. Benchmark Diff -------------------------------------------------------------------- WasmSpeedTest_empty -0.0185 WasmSpeedTest_get_current_time -0.1184 WasmSpeedTest_small_string -0.0081 WasmSpeedTest_small_string1000 -0.1324 WasmSpeedTest_small_string_check_compiler -0.0654 WasmSpeedTest_small_string_check_compiler1000 -0.1338 WasmSpeedTest_large_string -0.3187 WasmSpeedTest_large_string1000 -0.3624 WasmSpeedTest_get_property -0.0213 WasmSpeedTest_grpc_service -0.1426 WasmSpeedTest_grpc_service1000 -0.2431 WasmSpeedTest_modify_metadata -0.0287 WasmSpeedTest_modify_metadata1000 -0.0431 WasmSpeedTest_json_serialize -0.2729 WasmSpeedTest_json_deserialize -0.2594 WasmSpeedTest_json_deserialize_empty -0.2609 WasmSpeedTest_convert_to_filter_state -0.2889 Signed-off-by: Piotr Sikora <[email protected]>
|
Let's wait for all Envoy tests to pass before merging this (envoyproxy/envoy#15801). |
mathetake
reviewed
Apr 1, 2021
|
How did you find this option? 😄 this is awesome |
V8 team, mostly as a result of my complains about the limited number of WasmVMs: |
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves performance by up to 36% in microbenchmarks.
Benchmark Diff
WasmSpeedTest_empty -0.0185
WasmSpeedTest_get_current_time -0.1184
WasmSpeedTest_small_string -0.0081
WasmSpeedTest_small_string1000 -0.1324
WasmSpeedTest_small_string_check_compiler -0.0654
WasmSpeedTest_small_string_check_compiler1000 -0.1338
WasmSpeedTest_large_string -0.3187
WasmSpeedTest_large_string1000 -0.3624
WasmSpeedTest_get_property -0.0213
WasmSpeedTest_grpc_service -0.1426
WasmSpeedTest_grpc_service1000 -0.2431
WasmSpeedTest_modify_metadata -0.0287
WasmSpeedTest_modify_metadata1000 -0.0431
WasmSpeedTest_json_serialize -0.2729
WasmSpeedTest_json_deserialize -0.2594
WasmSpeedTest_json_deserialize_empty -0.2609
WasmSpeedTest_convert_to_filter_state -0.2889
Signed-off-by: Piotr Sikora [email protected]