Skip to content

Remove unused protobuf dependency. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ cc_library(
deps = [
":include",
"@boringssl//:crypto",
"@com_google_protobuf//:protobuf_lite",
"@proxy_wasm_cpp_sdk//:api_lib",
],
)
Expand Down
3 changes: 0 additions & 3 deletions bazel/external/proxy-wasm-cpp-sdk.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,4 @@ cc_library(
"proxy_wasm_common.h",
"proxy_wasm_enums.h",
],
deps = [
"@com_google_protobuf//:protobuf_lite",
],
)
7 changes: 0 additions & 7 deletions bazel/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,6 @@ def proxy_wasm_cpp_host_repositories():
url = "https://github.com/bazelbuild/rules_rust/archive/96d5118f03411f80182fd45426e259eedf809d7a.tar.gz",
)

http_archive(
name = "com_google_protobuf",
sha256 = "59621f4011a95df270748dcc0ec1cc51946473f0e140d4848a2f20c8719e43aa",
strip_prefix = "protobuf-655310ca192a6e3a050e0ca0b7084a2968072260",
url = "https://github.com/protocolbuffers/protobuf/archive/655310ca192a6e3a050e0ca0b7084a2968072260.tar.gz",
)

http_archive(
name = "rules_foreign_cc",
sha256 = "d54742ffbdc6924f222d2179f0e10e911c5c659c4ae74158e9fe827aad862ac6",
Expand Down
1 change: 0 additions & 1 deletion include/proxy-wasm/null_plugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#include <memory>

#include "google/protobuf/message.h"
#include "include/proxy-wasm/null_vm_plugin.h"
#include "include/proxy-wasm/wasm.h"
#include "include/proxy-wasm/exports.h"
Expand Down
11 changes: 11 additions & 0 deletions include/proxy-wasm/wasm_api_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@

#pragma once

// Required by "proxy_wasm_api.h" included within null_plugin namespace.

#include <cstring>
#include <functional>
#include <memory>
#include <string>
#include <tuple>
#include <unordered_map>
#include <utility>
#include <vector>

namespace proxy_wasm {
namespace null_plugin {

Expand Down