Skip to content

Make HTTP/gRPC callout IDs unique per WasmVM instance. #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

PiotrSikora
Copy link
Member

Fixes #185.

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora PiotrSikora requested a review from mathetake as a code owner August 12, 2021 03:45
@mathetake
Copy link
Contributor

Run go get -u github.com/google/addlicense
  go get -u github.com/google/addlicense
  export PATH=$PATH:$(go env GOPATH)/bin
  addlicense -check .
  shell: /usr/bin/bash -e {0}
package io/fs: unrecognized import path "io/fs": import path does not begin with hostname
Error: Process completed with exit code 1.

I imagine addlicense introduced new dependency which uses a new API of Go stdlib, which is not available in the default Go version on Ubuntu VM. maybe we should ping the version of addlicense?

Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the change

@PiotrSikora
Copy link
Member Author

I imagine addlicense introduced new dependency which uses a new API of Go stdlib, which is not available in the default Go version on Ubuntu VM. maybe we should ping the version of addlicense?

Yeah, I'm already working on that, although ubuntu-latest should have Go 1.16.6, so it's a bit bizzare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP/gRPC callout IDs should be unique per WasmVM
2 participants