Skip to content

wasmtime: update to v0.31.0. #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2021
Merged

wasmtime: update to v0.31.0. #196

merged 3 commits into from
Nov 12, 2021

Conversation

PiotrSikora
Copy link
Member

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora
wasmtime: update to v0.31.0.
57ec3cd 
Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora PiotrSikora requested a review from mathetake November 2, 2021 09:40
@PiotrSikora
Copy link
Member Author

Envoy PR: envoyproxy/envoy#18860

@PiotrSikora
Copy link
Member Author

Bazel Query (in Envoy PR) complains about duplicated dependency on libc in errno crate, but they are in separate selects.with_or statements, so it's a false positive. Those build rules are auto-generated by cargo-raze and correct, so I'm not sure what's the best fix here... Maybe manual concatenation of selects.with_or statements?

@PiotrSikora
Copy link
Member Author

cargo-raze issue tracked here: google/cargo-raze#451, but let's get this in with manual fixes in the meantime.

mathetake
mathetake approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 👍

@PiotrSikora PiotrSikora merged commit e0636f7 into proxy-wasm:master Nov 12, 2021
@PiotrSikora PiotrSikora mentioned this pull request Dec 16, 2021
Merged
@PiotrSikora PiotrSikora mentioned this pull request Dec 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiotrSikora @mathetake