Review of the ContextBase include file.

BUILD

@@ -6,6 +6,7 @@ cc_library(
     name = "include",
     hdrs = [
         "include/proxy-wasm/compat.h",
+        "include/proxy-wasm/context.h",
         "include/proxy-wasm/wasm_vm.h",
         "include/proxy-wasm/word.h",
     ],
@@ -19,6 +20,7 @@ cc_library(
     name = "include14",
     hdrs = [
         "include/proxy-wasm/compat.h",
+        "include/proxy-wasm/context.h",
         "include/proxy-wasm/wasm_vm.h",
         "include/proxy-wasm/word.h",
     ],
@@ -33,9 +35,16 @@ cc_test(
     srcs = ["wasm_vm_test.cc"],
     deps = [
         ":include",
-        "@com_google_absl//absl/base",
-        "@com_google_absl//absl/strings:strings",
-        "@com_google_absl//absl/types:optional",
+        "@com_google_googletest//:gtest",
+        "@com_google_googletest//:gtest_main",
+    ],
+)
+
+cc_test(
+    name = "context_test",
+    srcs = ["context_test.cc"],
+    deps = [
+        ":include",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
     ],
@@ -55,3 +64,17 @@ cc_test(
         "@com_google_googletest//:gtest_main",
     ],
 )
+
+cc_test(
+    name = "context_14_test",
+    srcs = ["context_test.cc"],
+    copts = ["-std=c++14"],
+    deps = [
+        ":include14",
+        "@com_google_absl//absl/base",
+        "@com_google_absl//absl/strings:strings",
+        "@com_google_absl//absl/types:optional",
+        "@com_google_googletest//:gtest",
+        "@com_google_googletest//:gtest_main",
+    ],
+)

VERSIONING.md

@@ -0,0 +1,3 @@
+# ABI Versioning
+
+TODO

context_test.cc

@@ -0,0 +1,20 @@
+#include "include/proxy-wasm/context.h"
+
+#include "gtest/gtest.h"
+
+namespace proxy_wasm {
+namespace {
+
+class Context : public ContextBase {
+public:
+  Context(std::function<void(string_view s)> error_function) : error_function_(error_function) {}
+  void error(string_view message) { error_function_(message); }
+
+private:
+  std::function<void(string_view s)> error_function_;
+};
+
+TEST(Context, IncludeParses) {}
+
+} // namespace
+} // namespace proxy_wasm

include/proxy-wasm/compat.h

@@ -17,16 +17,12 @@
 // Provide compatibiliby for projects which have not yet moved to C++17.
 // TODO: remove this when all dependent projects have upgraded.
 
-#ifndef __cpp_lib_optional
-#include "absl/types/optional.h"
-#else
+#if __cplusplus >= 201703L
 #include <optional>
-#endif
-
-#ifndef __cpp_lib_string_view
-#include "absl/strings/string_view.h"
-#else
 #include <string_view>
+#else
+#include "absl/types/optional.h"
+#include "absl/strings/string_view.h"
 #endif
 
 namespace proxy_wasm {