-
Notifications
You must be signed in to change notification settings - Fork 73
wasmtime: update to v1.0.1. #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf997da
to
d20d588
Compare
Thanks @RiverPhillips ! Hope you changed the cargo version to 0.14.1 as the steps I pointed to was a bit older one with version 0.12 |
Cheers @kfaseela - I tried 16 but will try it again with 14 |
77d2e51
to
f5e24eb
Compare
Looks like I'm still getting the following error. Seems like this is a transient reference - not sure the best way to resolve
|
You need to manually remove duplicate dependencies from It should be pretty obvious what to remove when you compare the diff to the current version. |
1117246
to
12b7819
Compare
Apologies for the force push, forgot the DCO. I believe that should resolve it |
Hi @RiverPhillips, the latest commit in the series is wrong. It removes a legitimate dependency. You need to manually remove duplicate |
Cheers @PiotrSikora I'll revisit ths when I can. I moved this weekend and don't yet have an Internet connection |
This is still missing and results in test failing. You might be able to apply that patch directly after updating the crate versions. |
Hi @PiotrSikora, sorry it's taken me a while to get this done bazel query 'deps(//bazel/cargo/...)'
cd wasmsign && cargo raze && cd ..
cd wasmtime && cargo raze && cd ..
# Ignore manual changes in "errno" and "rustix" crates until fixed in cargo-raze.
# See: https://github.com/google/cargo-raze/issues/451
git diff --exit-code -- ':!wasmtime/remote/BUILD.errno-0.*.bazel' ':!wasmtime/remote/BUILD.rustix-0.*.bazel' Is now running for me locally so it appears I've finally resolved this |
You need to remove the |
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
This reverts commit 12b7819. Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
This reverts commit b19db1b. Signed-off-by: river phillips <[email protected]>
This reverts commit ea87e0f. Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Hi @RiverPhillips, you need to again remove the duplicate |
Signed-off-by: river phillips <[email protected]>
🤦♂️ I've been overwriting my changes when I've tried validating them. |
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
Signed-off-by: river phillips <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do you want to do v2.0.0 next? ;)
Sure, hopefully I know what I'm doing now 😅 |
Signed-off-by: river phillips <[email protected]>
Upgrade wasmtime to v1.0.0