Skip to content

Update rules_rust to v0.19.0 (with Rust v1.68.0). #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Update rules_rust to v0.19.0 (with Rust v1.68.0). #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ce57f0
deps: bump rust -> 1.68.0
RiverPhillips Mar 19, 2023
d4244cd
deps: bump rules_rust -> 0.19.0
RiverPhillips Mar 19, 2023
f12e348
fix checksum
RiverPhillips Mar 19, 2023
0420bc1
fix stripping
RiverPhillips Mar 19, 2023
abf085c
fix failing test
RiverPhillips Mar 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bazel/dependencies.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def proxy_wasm_cpp_host_dependencies():
"wasm32-unknown-unknown",
"wasm32-wasi",
],
version = "1.62.1",
version = "1.68.0",
)
rust_repository_set(
name = "rust_linux_s390x",
Expand All @@ -48,7 +48,7 @@ def proxy_wasm_cpp_host_dependencies():
"wasm32-unknown-unknown",
"wasm32-wasi",
],
version = "1.62.1",
version = "1.68.0",
)

zig_register_toolchains(
Expand Down
6 changes: 3 additions & 3 deletions bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ def proxy_wasm_cpp_host_repositories():
maybe(
http_archive,
name = "rules_rust",
sha256 = "f3d443e9ad1eca99fbcade1c649adbd8200753cf22e47846b3105a43a550273b",
strip_prefix = "rules_rust-0.8.1",
sha256 = "c8a84a01bff4be4c7a8beefbc12e713ff296fed2110c30572a44205856594cfc",
strip_prefix = "rules_rust-0.19.0",
# NOTE: Update Rust version in bazel/dependencies.bzl.
url = "https://github.com/bazelbuild/rules_rust/archive/0.8.1.tar.gz",
url = "https://github.com/bazelbuild/rules_rust/archive/0.19.0.tar.gz",
patches = ["@proxy_wasm_cpp_host//bazel/external:rules_rust.patch"],
patch_args = ["-p1"],
)
Expand Down
2 changes: 1 addition & 1 deletion test/runtime_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ TEST_P(TestVm, WasmMemoryLimit) {
// Backtrace
if (engine_ == "v8") {
EXPECT_TRUE(host->isErrorLogged("Proxy-Wasm plugin in-VM backtrace:"));
EXPECT_TRUE(host->isErrorLogged(" - rust_oom"));
EXPECT_TRUE(host->isErrorLogged("rust_oom"));
EXPECT_TRUE(host->isErrorLogged(" - alloc::alloc::handle_alloc_error"));
}
}
Expand Down