-
Notifications
You must be signed in to change notification settings - Fork 73
Cache canary results. #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
@ingwonsong @mpwarres @martijneken could you take a look? Thanks! |
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
IIUC, with this PR, we don't make a canary for each VMs. (just doing canary for each plugin). |
Can you elaborate on what you mean by a heterogeneous VM? I think the behavior should be the same with or without this PR since we simply cache the result of a computation, assuming plugin_key uniquely identifies an instance. In the future, this needs to be completely changed so that we only configure once on the main instead of the thread-locals. But given that we have a separate thread local cache already, I think we can delay that. |
I meant multiple types of wasm vm engines with "heterogenous" Wasm VM. LGTM. |
After having more chat with @kyessenov, I understood that the canary is cached per WasmHandle, so even though there are multiple types of VM engines, each of them will take canary tests. |
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
@PiotrSikora main merge broke CLA :) |
Argh, I don't know why GitHub UI decided to use my @google.com email instead of the primary one. Could you remove my commit and push your own merge? |
fd6fde5
to
c9b9238
Compare
@PiotrSikora done and force-pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #350