Skip to content

Cache canary results. #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 11, 2023
Merged

Conversation

kyessenov
Copy link
Collaborator

Fixes #350

Signed-off-by: Kuat Yessenov <[email protected]>
kyessenov added 2 commits May 4, 2023 04:56
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
@PiotrSikora
Copy link
Member

@ingwonsong @mpwarres @martijneken could you take a look? Thanks!

Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
@ingwonsong
Copy link
Contributor

IIUC, with this PR, we don't make a canary for each VMs. (just doing canary for each plugin).
Would there be any chance to use heterogenous VMs with the same Plugin?
(I don't think this situation is realistic, but just want to check your thoughts.)

@kyessenov
Copy link
Collaborator Author

Can you elaborate on what you mean by a heterogeneous VM? I think the behavior should be the same with or without this PR since we simply cache the result of a computation, assuming plugin_key uniquely identifies an instance.

In the future, this needs to be completely changed so that we only configure once on the main instead of the thread-locals. But given that we have a separate thread local cache already, I think we can delay that.

@ingwonsong
Copy link
Contributor

I meant multiple types of wasm vm engines with "heterogenous" Wasm VM.
BTW, I agree that it would be very rare case, and even if it happen, the difference of VM engine should not affect the result of canary.

LGTM.

@ingwonsong
Copy link
Contributor

After having more chat with @kyessenov, I understood that the canary is cached per WasmHandle, so even though there are multiple types of VM engines, each of them will take canary tests.

@mpwarres mpwarres self-assigned this May 8, 2023
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
@kyessenov
Copy link
Collaborator Author

@PiotrSikora main merge broke CLA :)

@PiotrSikora
Copy link
Member

@PiotrSikora main merge broke CLA :)

Argh, I don't know why GitHub UI decided to use my @google.com email instead of the primary one.

Could you remove my commit and push your own merge?

@kyessenov kyessenov force-pushed the cache_onconfigure branch from fd6fde5 to c9b9238 Compare May 10, 2023 18:25
@kyessenov
Copy link
Collaborator Author

@PiotrSikora done and force-pushed.

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora changed the title cache canary results Cache canary results. May 11, 2023
@PiotrSikora PiotrSikora merged commit e1fe5e9 into proxy-wasm:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache onConfigure results
4 participants