Skip to content

Use SHA256 hash for plugin cache. #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

phmx
Copy link
Contributor

@phmx phmx commented Jul 2, 2023

Use SHA256 hash for plugin cache key. Otherwise, a raw plugin config (concatenated with root ID and key) is stored in the key which may cause unnecessary memory consumption.

Use SHA256 hash for plugin cache key. Otherwise, a raw plugin
config (concatenated with root ID and key) is stored in the key which
may cause unnecessary memory consumption.

Signed-off-by: Maxim Philippov <[email protected]>
@phmx phmx force-pushed the sha-hash-plugins-cache-keys branch from ad0aaa8 to d493cc6 Compare July 2, 2023 11:11
@PiotrSikora PiotrSikora changed the title Use SHA256 hash for plugin cache Use SHA256 hash for plugin cache. Jul 2, 2023
@PiotrSikora PiotrSikora requested review from mpwarres and kyessenov July 2, 2023 22:44
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mpwarres mpwarres merged commit c932df1 into proxy-wasm:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants