Skip to content

Remove no longer needed Emscripten metadata. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

PiotrSikora
Copy link
Member

Signed-off-by: Piotr Sikora [email protected]

Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this was what I was thinking about. Just curious, what's the original purpose of getting emscripten information?

@PiotrSikora
Copy link
Member Author

We needed it to get memory offsets to initialize some pointers at startup, but nowadays that's handled by crt1 constructors emitted by Emscripten.

@PiotrSikora PiotrSikora merged commit 2d4bfe9 into proxy-wasm:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants