Skip to content

v8: enhance signature mimatch message in getModuleFunction #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mathetake
Copy link
Contributor

Signed-off-by: mathetake [email protected]

resolves #74

the following is an example message:

[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 -> i32, but the module exports: i32 i32 -> i32
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> i32, but the module exports: i32 i32 -> i32
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> i32, but the module exports: i32 i32 -> i32
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> i32, but the module exports: i32 i32 -> i32
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> i32, but the module exports: i32 i32 -> i32
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 -> i32, but the module exports: i32 i32 -> i32
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 -> void, but the module exports: i32 i32 -> void
[source/extensions/common/wasm/wasm_vm.cc:29] Bad function signature for: proxy_on_vm_start, want: i32 i32 i32 -> void, but the module exports: i32 i32 -> void

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sans nit.

@PiotrSikora PiotrSikora merged commit 8d0727f into proxy-wasm:master Oct 27, 2020
@mathetake mathetake deleted the get-module-function-sinature-mimatch branch October 27, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance signature mismatch error message in getModuleFunctionImpl for V8
2 participants