-
-
Notifications
You must be signed in to change notification settings - Fork 21
Release 3.0.0 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0.0 #46
Conversation
@jdnichollsc I have begun testing/debugging this next release. I have corrected some minor lint errors and discovered the CI iOS builds are failing. Will report more when I find more. |
Fix minor lint errors
Thanks for your help mate! Demo project is not working in my local environment and I don’t know why, also I need to debug these TODOs:
I don’t know if Also we need to update README, because some imports ( |
I am afraid you may be more knowledgeable in this regard than me. It may be possible to use an event listener and track state rather than depend on the paused property as an indication the app state is active. https://docs.nativescript.org/core-concepts/application-lifecycle#android-activity-events |
On a good note, I have tested all the use cases I have. That is Facebook, LinkedIn, and Google on Android and iOS. The only failure, which existed before, is that on android API 27+ Google OAuth callback does not return back to the application. I am still trying to determine if this is Chrome blocking the redirect back or if the app is not activating its intent. |
Ohh yes mate, we're already using activity events here: https://github.com/proyecto26/nativescript-inappbrowser/blob/develop/src/utils.android.ts#L106 |
Ok, I removed TODOs, it's working as expected! <3 I need help with the CI issue 😅 |
This may work, #48 |
@jdnichollsc let me know if there is anything else, in particular, I can review/test/debug. |
Thanks a lot William for your help! |
Glad I can help. |
Haha happy Halloween! 😸 |
@jdnichollsc Thank you for the work you put into this plugin! Sorry it took so long for me to get back, I have been out of town. Hopefully, I can work on the integration today. Again, thank you for your time and effort. |
Added
hasBackButton
option to sets a back arrow instead of the default X icon to close the custom tab.browserPackage
option to use a Package name of a browser to be used to handle Custom Tabs.showInRecents
option to determine whether browsed website should be shown as separate entry in Android recents/multitasking view.Fixed
isAvailable
method checks Custom Tab support.redirectResolve
insafariViewControllerDidFinish
.AppStateActiveOnce
event listener.