#186 openAuth crashed when going to be closed and then press the cancel button #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the cancel button
jdnichollsc
reviewed
Apr 7, 2021
ios/RNInAppBrowser.m
Outdated
| redirectResolve(@{ | ||
| @"type" : @"success", | ||
| @"url" : url, | ||
| }); |
There was a problem hiding this comment.
hello mate, can you fix indentation please?
There was a problem hiding this comment.
Hi, Thank you for review!
I fixed it.
|
Thanks for your contribution! <3 |
|
Hey @jdnichollsc are you planning on a release with this fix? Thanks |
|
Today <3 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
openAuth crashed when going to be closed and then press the cancel button.
The completionHandler was called, then redirectResolve to be null by flowDidFinish. After that completionHandler be call again by press the cancel button.
redirectResolve is null, and so crash.
What is the new behavior?
No more crash.
Fixes/Implements/Closes #186.