Skip to content

FIX: Understand XMLDocument and HTMLDocument as Document responses #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

eric-corumdigital
Copy link
Contributor

@eric-corumdigital eric-corumdigital commented Nov 30, 2020

Description of the change
Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@thomashoneyman thomashoneyman added the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 5, 2020
Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this, but we should add it to the CHANGELOG. Would you mind adding a description of this change there, at which point I can merge it in?

@thomashoneyman thomashoneyman changed the title FIX: Allow XMLDocument and HTMLDocument to be understood as a valid D… FIX: Understand XMLDocument and HTMLDocument as Document responses Dec 9, 2020
@thomashoneyman thomashoneyman merged commit f907dd3 into purescript-contrib:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0
Development

Successfully merging this pull request may close these issues.

2 participants