Skip to content

Non-empty combinators return NonEmptyList #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 17, 2020
Merged

Non-empty combinators return NonEmptyList #102

merged 4 commits into from
Dec 17, 2020

Conversation

robertdp
Copy link
Collaborator

@robertdp robertdp commented Dec 16, 2020 •
edited
Loading

For #83

robertdp
robertdp commented Dec 16, 2020
View reviewed changes
thomashoneyman
thomashoneyman reviewed Dec 17, 2020
View reviewed changes
src/Text/Parsing/Parser/Combinators.purs
many1Till p end = do
x <- p
xs <- manyTill p end
pure (x:xs)
pure (cons' x xs)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

thomashoneyman
thomashoneyman approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thomashoneyman thomashoneyman merged commit fe969c3 into purescript-contrib:main Dec 17, 2020
@jamesdbrock
Copy link
Member

Thank you @robertdp !

@robertdp robertdp deleted the nonempty-combinators branch December 19, 2020 12:51
@thomashoneyman thomashoneyman mentioned this pull request Mar 2, 2021
Merged
@yzyzsun yzyzsun mentioned this pull request May 2, 2021
Closed
@robertdp robertdp mentioned this pull request Jun 7, 2021
Merged
4 tasks
garyb pushed a commit that referenced this pull request Jun 9, 2021
@robertdp
Revert combinator changes from PR #102 (#116)
88e0822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertdp @jamesdbrock @thomashoneyman