Implement ability to switch from .purs to .js FFI file #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-Angel
force-pushed
the
impl-ability-so-switch-to-js-ffi
branch
from
3ff2fde to
00076da
Compare
purcell
requested changes
Dec 9, 2024
purescript-mode.el
Outdated
| (setq prettify-symbols-alist purescript-font-lock-prettify-symbols-alist) | ||
| (setq prettify-symbols-alist purescript-font-lock-prettify-symbols-alist | ||
| ;; make (ff-find-other-file) find .js FFI file, given .purs | ||
| ff-other-file-alist '((".purs$" (".js")))) |
There was a problem hiding this comment.
Suggested change
| ff-other-file-alist '((".purs$" (".js")))) | |
| ff-other-file-alist '((".purs\\'" (".js")))) |
End-of-string match should be preferred to end-of-line match for filenames, as in auto-mode-alist.
Emacs provides a `(ff-find-other-file nil t)` function to switch between header and implementations. The closest PureScript has to such idea is the FFI, where given `Foo.purs` there has to be similarly named `Foo.js`, and unsurprisingly I keep pressing a keybind trying to switch between them. So add the mapping from `.purs` to `.js`. Worth noting that this doesn't provide the reverse mapping `.js → .purs` because js is a different major mode and we can't be making assumptions on whether it's related to PureScript… Usually. We probably could reassign in case the js file was open by the `ff-find-other-file`, but let's keep it simple for now.
Hi-Angel
force-pushed
the
impl-ability-so-switch-to-js-ffi
branch
from
00076da to
32938fc
Compare
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs provides a
(ff-find-other-file nil t)function to switch between header and implementations. The closest PureScript has to such idea is the FFI, where givenFoo.pursthere has to be similarly namedFoo.js, and unsurprisingly I keep pressing a keybind trying to switch between them.So add the mapping from
.pursto.js.Worth noting that this doesn't provide the reverse mapping
.js → .pursbecause js is a different major mode and we can't be making assumptions on whether it's related to PureScript… Usually. We probably could reassign in case the js file was open by theff-find-other-file, but let's keep it simple for now.