Skip to content

make getCanvasElementById safe, fixes #2 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = function(grunt) {
},
main: {
files: {
src: ["src/**/*.purs"]
src: ["src/**/*.purs", "bower_components/**/src/**/*.purs"]
}
},
},
Expand Down
18 changes: 10 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Types

type Arc = { end :: Number, start :: Number, r :: Number, y :: Number, x :: Number }
type Arc = { end :: Number, start :: Number, r :: Number, y :: Number, x :: Number }

data Canvas :: !

Expand All @@ -27,7 +27,7 @@

data Context2D :: *

type Dimensions = { height :: Number, width :: Number }
type Dimensions = { height :: Number, width :: Number }

data ImageData :: *

Expand All @@ -36,15 +36,15 @@
Square :: LineCap
Butt :: LineCap

type Rectangle = { h :: Number, w :: Number, y :: Number, x :: Number }
type Rectangle = { h :: Number, w :: Number, y :: Number, x :: Number }

type ScaleTransform = { scaleY :: Number, scaleX :: Number }
type ScaleTransform = { scaleY :: Number, scaleX :: Number }

type TextMetrics = { width :: Number }
type TextMetrics = { width :: Number }

type Transform = { m32 :: Number, m31 :: Number, m22 :: Number, m21 :: Number, m12 :: Number, m11 :: Number }
type Transform = { m32 :: Number, m31 :: Number, m22 :: Number, m21 :: Number, m12 :: Number, m11 :: Number }

type TranslateTransform = { translateY :: Number, translateX :: Number }
type TranslateTransform = { translateY :: Number, translateX :: Number }


### Type Class Instances
Expand Down Expand Up @@ -82,7 +82,9 @@

getCanvasDimensions :: forall eff. CanvasElement -> Eff (canvas :: Canvas | eff) Dimensions

getCanvasElementById :: forall eff. String -> Eff (canvas :: Canvas | eff) CanvasElement
getCanvasElementById :: forall eff. String -> Eff (canvas :: Canvas | eff) (Maybe CanvasElement)

getCanvasElementByIdImpl :: forall a eff. Fn3 String (a -> Maybe a) (Maybe a) (Eff (canvas :: Canvas | eff) (Maybe CanvasElement))

getCanvasHeight :: forall eff. CanvasElement -> Eff (canvas :: Canvas | eff) Number

Expand Down
5 changes: 4 additions & 1 deletion bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,8 @@
"bower_components",
"test",
"tests"
]
],
"dependencies": {
"purescript-maybe": "~0.2.1"
}
}
29 changes: 23 additions & 6 deletions src/Graphics/Canvas.purs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
module Graphics.Canvas where

import Data.Function
import Data.Maybe
import Control.Monad.Eff

foreign import data Canvas :: !
Expand All @@ -12,12 +14,27 @@ foreign import data ImageData :: *

foreign import data CanvasPixelArray :: *

foreign import getCanvasElementById
"function getCanvasElementById(id) {\
\ return function() {\
\ return document.getElementById(id);\
\ };\
\}" :: forall eff. String -> Eff (canvas :: Canvas | eff) CanvasElement
foreign import getCanvasElementByIdImpl
"""function getCanvasElementByIdImpl(id, Just, Nothing) {
return function() {
var el = document.getElementById(id);
if (el && el instanceof HTMLCanvasElement) {
return Just(el);
} else {
return Nothing;
}
};
}""" :: forall a eff.
Fn3
String
(a -> Maybe a)
(Maybe a)
(Eff (canvas :: Canvas | eff) (Maybe CanvasElement))

getCanvasElementById :: forall eff.
String -> Eff (canvas :: Canvas | eff) (Maybe CanvasElement)
getCanvasElementById elId =
runFn3 getCanvasElementByIdImpl elId Just Nothing

foreign import getContext2D
"function getContext2D(c) {\
Expand Down