Skip to content

Add Eq1 and Ord1 instances, fix Eq/Ord #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Add Eq1 and Ord1 instances, fix Eq/Ord #72

merged 1 commit into from
Mar 27, 2017

Conversation

garyb
Copy link
Member

@garyb garyb commented Mar 2, 2017

Resolves #71

@paf31 this one probably could use an actual review...

What do you think about versioning this - minor bump? It is a breaking change, but it's fixing something that was actually unusable before.

@paf31
Copy link
Contributor

paf31 commented Mar 2, 2017

Well, it wasn't completely unusable. Free (Const a) would have worked, for example. I think for that reason it should be a major release. We have a few libraries which need major releases soon anyway.

@garyb
Copy link
Member Author

garyb commented Mar 2, 2017

Right you are. I'll hold off on this until then then :)

@garyb garyb merged commit 5f59862 into master Mar 27, 2017
@garyb garyb deleted the eq-ord-1 branch March 27, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eq and Ord are unusable for Free and Cofree
2 participants