Validate all the things #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof channel !== "string" || channel === "") { | ||
| throw new Error("Invalid channel name: '" + channel + "'"); | ||
| } | ||
| validateSocketId(socketId); |
There was a problem hiding this comment.
Could we please have some test cases for validating the socket_id?
| } | ||
|
|
||
| var validateSocketId = function(socketId) { | ||
| if (typeof socketId !== "string" || socketId === "" || !socketId.match(/^\d+\.\d+$/)) { |
There was a problem hiding this comment.
\A and \Z aren't valid in JS. ^ and $ work the same, except in multiline mode. I have checked this.
danielwaterworth
force-pushed
the
validate_socket_id
branch
from
e55e9b1 to
731c0c8
Compare
kashif
pushed a commit
to kashif/pusher-http-node
that referenced
this pull request
May 18, 2015
Validate all the things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.