Skip to content

fix: instead of letting the app crash, handle the exception properly in React Native. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2023
Merged

fix: instead of letting the app crash, handle the exception properly in React Native. #104

merged 3 commits into from
Jul 26, 2023

Conversation

callaars
Copy link
Contributor

@callaars callaars commented Jul 4, 2023

Description

Instead of letting the app do a hard crash, make sure that we do a proper promise.reject() when we fail to subscribe to the channel.

CHANGELOG

  • [FIXED] Use a promise.resolve when you cannot subscribe to a channel.

@fbenevides
Copy link
Contributor

Hey @callaars, could you please update this branch with main?

@fbenevides fbenevides merged commit b5ec040 into pusher:master Jul 26, 2023
@callaars callaars deleted the hotfix/app-crash branch July 26, 2023 12:21
@fbenevides fbenevides mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbenevides fbenevides fbenevides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callaars @fbenevides