add custom authorizer example #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update java dependency and update deprecations
fbenevides
reviewed
Jul 21, 2022
android/build.gradle
Outdated
| @@ -124,5 +123,6 @@ dependencies { | |||
| // noinspection GradleDynamicVersion | |||
| api 'com.facebook.react:react-native:+' | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" | |||
| api 'com.pusher:pusher-java-client:2.2.8' | |||
| api 'com.pusher:pusher-java-client:+' | |||
There was a problem hiding this comment.
Isn't better to define a specific version?
There was a problem hiding this comment.
BTW, the latest one is 2.4.0
fbenevides
reviewed
Jul 21, 2022
| @@ -54,7 +55,21 @@ export default function App() { | |||
| await pusher.init({ | |||
| apiKey, | |||
| cluster, | |||
| // authEndpoint: '<Add your Auth Endpoint here>', | |||
| // authEndpoint | |||
There was a problem hiding this comment.
Also, I think we can add this information to the README file. WDYT?
fbenevides
approved these changes
Jul 21, 2022
added 2 commits
July 21, 2022 15:35
…t-react-native into custom-authorizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a short description of the change. If this is related to an issue, please add a reference to the issue.
CHANGELOG