Skip to content

Change subscribe function to consider private-encrypted channels #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2022
Merged

Change subscribe function to consider private-encrypted channels #5

merged 3 commits into from
Jun 29, 2022

Conversation

fbenevides
Copy link
Contributor

@fbenevides fbenevides commented Jun 28, 2022 •
edited
Loading

This PR fixes #4 & #6

We should check if a channel name is a private-encrypted before checking if it's a private one.

@fbenevides fbenevides added the bug Something isn't working label Jun 28, 2022
proggen-com
proggen-com approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@proggen-com proggen-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@proggen-com proggen-com merged commit d7ac973 into master Jun 29, 2022
@fbenevides fbenevides deleted the fix-private-encrypted-subscription branch June 29, 2022 14:02
@fbenevides fbenevides mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proggen-com proggen-com proggen-com approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not subscribe to a private encrypted channel on Android
2 participants
@fbenevides @proggen-com