Implement the Erbs model #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge as-is but, as always, make an issue/PR if you want to see something different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an implementation of the Erbs model based on
pvl_erbs.m. I was going to demonstrate this during the Santa Clara workshop, but didn't plan the time very well. Sorry.It's nearly a 1:1 port of the MATLAB function.
As currently written, the user must supply the day of the year, but we should consider that it instead be inferred from the index of the GHI Series. A potential downside of this is that it would require that ghi is a Series, instead of a numpy array. @mikofski might have something to say about that.
I'm open to making this change now, or merging as-is.
The PR also starts a 0.3.3 whatsnew file.
A gist with a simple example...
https://gist.github.com/wholmgren/21c9a60547a3f240aeb1a1919f8829b8
Here's the diff minus the unimportant whitespace changes...
https://github.com/pvlib/pvlib-python/pull/166/files?w=0