Skip to content

change authors, clean up setup.py #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2016
Merged

Conversation

wholmgren
Copy link
Member

Important! This changes the author list from

'Dan Riley, Clifford Hanson, Rob Andrews, Will Holmgren, github contributors'

to

'PVLIB Python Developers'

This is how most Python projects with more than one contributor do it. I also want to avoid arguments about who should be a named author and who shouldn't be.

For context, the author list for the first release of pvlib python was 'Dan Riley, Clifford Hanson, Rob Andrews'. I added myself and 'github contributors' at some point.

See #184 or the diff for a list of additional minor changes.

cc @cwhanse @Calama-Consulting @Heliolytics

closes #184.

@wholmgren wholmgren added this to the 0.3.3 milestone May 27, 2016
@Heliolytics
Copy link
Contributor

Good idea, no problems here. I think Sandia would want to make sure that there is still a clear link to the original code written at Sandia, but this can be taken care of outside of comments in the code base.

@wholmgren
Copy link
Member Author

Yes, I agree that it's essential to make the link to Sandia clear. For the record, we still credit Sandia in the first paragraph of the readthedocs page, the readme, the "long description" (the one that shows up on PyPI), and the copyright. So, I think we're covered, but it would be great to get confirmation from Josh, Cliff, or Dan.

@cwhanse
Copy link
Member

cwhanse commented May 31, 2016

Speaking on behalf of my colleagues, we're OK with the change in author list. In fact, our original vision was, and still is, a community built toolset. In the long description, I'd edit a bit to

pvlib-python was originally ported from the PVLIB MATLAB toolbox developed at Sandia
National Laboratories.

The credits on the readthedocs, and the request to cite publications, are spot on. Thanks.

Cliff

@wholmgren
Copy link
Member Author

Great, thanks! I like the edits too.

@wholmgren wholmgren merged commit aa643d5 into pvlib:master Jun 1, 2016
@wholmgren wholmgren deleted the setupfixes branch June 1, 2016 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more setup.py fixes
3 participants