Skip to content

Improve lookup_linke_turbidity speed #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2017
Merged

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Sep 5, 2017

  • Closes issue lookup_linke_turbidity is slow #368
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Updates entries to docs/sphinx/source/api.rst for API changes. (marked methods as private, so no action)
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

Improves the clearsky.lookup_linke_turbidity speed by 10-200x, depending on interpolation options and input data. See #368 for details.

@adriesse are you able to test this on your large dataset?

@wholmgren wholmgren added this to the 0.5.1 milestone Sep 5, 2017
@cwhanse
Copy link
Member

cwhanse commented Sep 5, 2017

Looks good to me

@adriesse
Copy link
Member

adriesse commented Sep 6, 2017

I'm afraid it would be difficult for me to test the new code. I have a workaround that I will leave in place until the next release. The only thing that matters though is the size of my time index, which is about 45M long with 1s freq.

@wholmgren wholmgren merged commit 853b121 into pvlib:master Sep 8, 2017
@wholmgren
Copy link
Member Author

Thanks for the review @cwhanse

@adriesse if it helps in the future...

you can install directly from github with pip install https://github.com/pvlib/pvlib-python/archive/master.zip

you can also replace the pvlib section of the url with another username, and the master section with the name of a branch. For example:
pip install https://github.com/wholmgren/pvlib-python/archive/ltspeed.zip

@wholmgren wholmgren deleted the ltspeed branch September 9, 2017 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants