Skip to content

solar_position_method arg passed to basic_chain method wasn't used #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 8, 2017
Merged

solar_position_method arg passed to basic_chain method wasn't used #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b0dd81
fix for issue #343
KonstantinTr Jul 12, 2017
49dfd58
test for issue #343
KonstantinTr Jul 12, 2017
1bd82fb
solar_position_method passed to basic_chain wasn't used causing
KonstantinTr Sep 6, 2017
abbd3b3
Merge pull request #1 from pvlib/master
KonstantinTr Sep 6, 2017
56b9e36
Update modelchain.py
KonstantinTr Sep 7, 2017
6bf61a8
Update v0.5.1.rst
KonstantinTr Sep 7, 2017
08245ba
Update v0.5.1.rst
KonstantinTr Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.5.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ API Changes
Bug fixes
~~~~~~~~~
* Remove condition causing Overflow warning from clearsky.haurwitz
* modelchain.basic_chain now correctly passes 'solar_position_method' arg to solarposition.get_solarposition
* Doc string of modelchain.basic_chain was updated to describe args more accurately

Enhancements
~~~~~~~~~~~~
Expand All @@ -26,3 +28,4 @@ Testing
Contributors
~~~~~~~~~~~~
* Cliff Hansen
* KonstantinTr
5 changes: 3 additions & 2 deletions pvlib/modelchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ def basic_chain(times, latitude, longitude,
Passed to system.get_irradiance.

solar_position_method : str, default 'nrel_numpy'
Passed to location.get_solarposition.
Passed to solarposition.get_solarposition.

airmass_model : str, default 'kastenyoung1989'
Passed to location.get_airmass.
Passed to atmosphere.relativeairmass.

altitude : None or float, default None
If None, computed from pressure. Assumed to be 0 m
Expand Down Expand Up @@ -129,6 +129,7 @@ def basic_chain(times, latitude, longitude,
longitude,
altitude=altitude,
pressure=pressure,
method=solar_position_method,
**kwargs)

# possible error with using apparent zenith with some models
Expand Down