-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add capability for reverse bias #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c95ac2a
add capability for reverse bias
cwhanse 4f07c04
lint, correct test_pvsyst_breakdown
cwhanse 90692a7
default value for breakdown_factor
cwhanse 70553fa
handle recombination in breakdown test, lint
cwhanse 4bb530c
correct parameter parsing
cwhanse 4bcb468
whatsnew
cwhanse bcb93bf
Update pvlib/tests/test_singlediode.py
cwhanse 32f8017
Update pvlib/singlediode.py
cwhanse 9dbfdf2
Update pvlib/singlediode.py
cwhanse 0ddde4c
fix formatting
cwhanse 21a7edc
improve docstring
cwhanse 9445d32
lint
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a convention, is it better to add new kwargs at the end, E.g. after
method='newton'
, so it doesn't break code that relies on position than explicitkwarg=
usage?I'm half asking if that's something that's been historically done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but would like to keep like arguments grouped together in general order of decreasing interest: required module parameters first, then optional thin-film parameters, reverse bias parameters third, numerical control last.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's bad form to rely on the position of a keyword argument. Don't worry about it.