Skip to content

Add transposition gain gallery example #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 6, 2020

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jun 10, 2020

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

A pretty simple example -- I always thought this was a cool plot and a good example of how easy it is to do powerful modeling with very little effort with pvlib. Built version:
https://pvlib-python--979.org.readthedocs.build/en/979/auto_examples/plot_transposition_gain.html

Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kanderso-nrel. I made some comments as I read through it but they are not blockers.

@wholmgren wholmgren added this to the 0.8.0 milestone Jul 4, 2020
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a suggested edit

@cwhanse cwhanse merged commit bf21779 into pvlib:master Jul 6, 2020
@cwhanse
Copy link
Member

cwhanse commented Jul 6, 2020

Thanks @kanderso-nrel

@kandersolar kandersolar deleted the transposition_gain_example branch July 6, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants