fix: escape Windows paths in STARTUP_CODE string formatting #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on Windows systems, the STARTUP_CODE template's __file__ assignment could fail due to unescaped backslashes in the Windows path. This occurs when formatting the path string into STARTUP_CODE, as Windows paths (e.g., "C:\Users\...") contain backslashes that need proper escaping in Python strings. The fix uses Path.as_posix() to convert Windows backslashes to forward slashes, which Python handles correctly across all operating systems. This ensures the path string is properly escaped when inserted into the STARTUP_CODE template. Technical details: - Uses existing pathlib.Path object's as_posix() method - Converts "C:\path\to\file" to "C:/path/to/file" - Maintains cross-platform compatibility - Fixes string formatting issues without changing functionality
|
Thanks @ijkwxyz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Windows systems, the STARTUP_CODE template's file assignment could fail due to unescaped backslashes in the Windows path. This occurs when formatting the path string into STARTUP_CODE, as Windows paths (e.g., "C:\Users...") contain backslashes that need proper escaping in Python strings.
The fix uses Path.as_posix() to convert Windows backslashes to forward slashes, which Python handles correctly across all operating systems. This ensures the path string is properly escaped when inserted into the STARTUP_CODE template.
Technical details: