Skip to content

adjust build for upload-artifact-4 #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2024
Merged

adjust build for upload-artifact-4 #1146

merged 2 commits into from
Jan 10, 2024

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #1146 (12bbf6b) into main (a1b934f) will increase coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 91.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
+ Coverage   89.88%   89.95%   +0.06%     
==========================================
  Files         106      106              
  Lines       16436    16438       +2     
  Branches       35       36       +1     
==========================================
+ Hits        14773    14786      +13     
+ Misses       1656     1645      -11     
  Partials        7        7              
Files Coverage Δ
python/pydantic_core/core_schema.py 94.76% <100.00%> (-0.01%) ⬇️
src/validators/mod.rs 95.37% <100.00%> (-0.02%) ⬇️
src/serializers/shared.rs 79.66% <0.00%> (-0.68%) ⬇️
src/serializers/type_serializers/tuple.rs 96.17% <96.10%> (+2.92%) ⬆️
src/validators/union.rs 89.41% <0.00%> (+1.80%) ⬆️
src/validators/tuple.rs 94.07% <92.92%> (+0.69%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df7624...12bbf6b. Read the comment docs.

@davidhewitt davidhewitt force-pushed the dh/fix-upload-artifact branch from 22f972d to 32346c3 Compare January 9, 2024 17:54
Copy link

codspeed-hq bot commented Jan 9, 2024

CodSpeed Performance Report

Merging #1146 will not alter performance

Comparing dh/fix-upload-artifact (12bbf6b) with main (4df7624)

Summary

✅ 140 untouched benchmarks

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling this fix 👍

@davidhewitt davidhewitt merged commit 82c4ca3 into main Jan 10, 2024
@davidhewitt davidhewitt deleted the dh/fix-upload-artifact branch January 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants